feat: fix PackageRequest schema inconsistency in adcp #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add impressions field to PackageRequest for impression goals - Add paused field to PackageRequest for creating packages in paused state - Add new property list management schemas for publisher property lists - Add extension metadata schemas - Add core/identifier.json and core/property-list-ref.json schemas - Update adagents, get-products, update-media-buy request/response schemas - Update enums: adcp-domain, task-type - Regenerate Python types from updated schemas
BaiyuScope3
force-pushed
the
feat/sync-package-schema-2.6
branch
from
636ebad to
a6c55db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix adcp package schema inconsistency issue link)
Sync schemas with ADCP 2.6 package updates.
Changes
PackageRequest
impressions- Impression goal for the packagepaused- Create packages in paused state (default: false)New Schemas
property/) - CRUD operations for publisher property listsextensions/) - Extension metadata schemascore/identifier.json,core/property-list-ref.jsonUpdated Schemas
adagents.jsonmedia-buy/get-products-request.json,get-products-response.jsonmedia-buy/update-media-buy-request.jsonenums/adcp-domain.json,enums/task-type.jsonprotocols/adcp-extension.jsonTesting
make test-fast